Addressed Terrence's comments

davidwitten · Jun 24, 2020 · 718dc7d · 718dc7d
1 parent fdd7740
commit 718dc7d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/packages/opentelemetry-exporter-collector/src/platform/browser/CollectorMetricExporter.ts b/packages/opentelemetry-exporter-collector/src/platform/browser/CollectorMetricExporter.ts
@@ -25,6 +25,9 @@ import { sendWithBeacon, sendWithXhr } from './util';
 
 const DEFAULT_COLLECTOR_URL = 'http://localhost:55678/v1/trace';
 
+/**
+ * Collector Metric Exporter for Web
+ */
 export class CollectorMetricExporter extends CollectorMetricExporterBase<
   CollectorExporterConfigBrowser
 > {

diff --git a/packages/opentelemetry-exporter-collector/src/platform/browser/CollectorTraceExporter.ts b/packages/opentelemetry-exporter-collector/src/platform/browser/CollectorTraceExporter.ts
@@ -24,7 +24,7 @@ import { sendWithBeacon, sendWithXhr } from './util';
 const DEFAULT_COLLECTOR_URL = 'http://localhost:55678/v1/trace';
 
 /**
- * Collector Exporter for Web
+ * Collector Trace Exporter for Web
  */
 export class CollectorTraceExporter extends CollectorTraceExporterBase<
   CollectorExporterConfigBrowser

diff --git a/packages/opentelemetry-exporter-collector/src/platform/node/CollectorMetricExporter.ts b/packages/opentelemetry-exporter-collector/src/platform/node/CollectorMetricExporter.ts
@@ -28,7 +28,7 @@ import { CollectorMetricExporterBase } from '../../CollectorMetricExporterBase';
 const DEFAULT_COLLECTOR_URL = 'localhost:55678';
 
 /**
- * Collector Exporter for Node
+ * Collector Metric Exporter for Node
  */
 export class CollectorMetricExporter extends CollectorMetricExporterBase<
   CollectorExporterConfigNode
@@ -91,6 +91,7 @@ export class CollectorMetricExporter extends CollectorMetricExporterBase<
     onError: (error: collectorTypes.CollectorExporterError) => void
   ): void {
     if (this.isShutDown) {
+      this.logger.debug('Shutdown already started. Cannot send metrics');
       return;
     }
     if (this.metricServiceClient) {

diff --git a/packages/opentelemetry-exporter-collector/src/platform/node/CollectorTraceExporter.ts b/packages/opentelemetry-exporter-collector/src/platform/node/CollectorTraceExporter.ts
@@ -32,7 +32,7 @@ import { removeProtocol } from './util';
 const DEFAULT_COLLECTOR_URL = 'localhost:55678';
 
 /**
- * Collector Exporter for Node
+ * Collector Trace Exporter for Node
  */
 export class CollectorTraceExporter extends CollectorTraceExporterBase<
   CollectorExporterConfigNode
@@ -100,6 +100,7 @@ export class CollectorTraceExporter extends CollectorTraceExporterBase<
     onError: (error: CollectorExporterError) => void
   ): void {
     if (this.isShutDown) {
+      this.logger.debug('Shutdown already started. Cannot send spans');
       return;
     }
     if (this.traceServiceClient) {