Addressed comments

davidwitten · Jun 26, 2020 · 4655a49 · 4655a49
1 parent d32bd6e
commit 4655a49
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/opentelemetry-exporter-collector/README.md b/packages/opentelemetry-exporter-collector/README.md
@@ -49,7 +49,7 @@ const collectorOptions = {
   headers: {}, //an optional object containing custom headers to be sent with each request
 };
 
-const exporter = new MetricExporter(collectorOptions);
+const exporter = new CollectorMetricExporter(collectorOptions);
 
 // Register the exporter
 const meter = new MeterProvider({
@@ -142,7 +142,7 @@ The CollectorMetricExporter in Node expects the URL to only be the hostname. It
 ```js
 const grpc = require('grpc');
 const { MeterProvider } = require('@opentelemetry/metrics');
-const { CollectorTraceExporter } =  require('@opentelemetry/exporter-collector');
+const { CollectorMetricExporter } =  require('@opentelemetry/exporter-collector');
 
 const metadata = new grpc.Metadata();
 metadata.set('k', 'v');
@@ -158,7 +158,7 @@ const collectorOptions = {
   metadata // Optional metadata
 };
 
-const exporter = new MetricExporter(collectorOptions);
+const exporter = new CollectorMetricExporter(collectorOptions);
 
 // Register the exporter
 const meter = new MeterProvider({

diff --git a/packages/opentelemetry-exporter-collector/src/platform/browser/CollectorMetricExporter.ts b/packages/opentelemetry-exporter-collector/src/platform/browser/CollectorMetricExporter.ts
@@ -23,7 +23,7 @@ import {
 } from '../../types';
 import { sendWithBeacon, sendWithXhr } from './util';
 
-const DEFAULT_COLLECTOR_URL = 'http://localhost:55678/v1/trace';
+const DEFAULT_COLLECTOR_URL = 'http://localhost:55678/v1/metrics';
 
 /**
  * Collector Metric Exporter for Web

diff --git a/packages/opentelemetry-exporter-collector/src/transform.ts b/packages/opentelemetry-exporter-collector/src/transform.ts
@@ -348,7 +348,7 @@ export function toCollectorType(
     }
     return opentelemetryProto.metrics.v1.MetricDescriptorType.MONOTONIC_DOUBLE;
   } else {
-    // Other types not yet implemented
+    // @TODO: Implement other metric kinds
     return opentelemetryProto.metrics.v1.MetricDescriptorType.INVALID_TYPE;
   }
 }
@@ -414,7 +414,7 @@ export function toCollectorMetric(
     int64DataPoints = [points];
   } else if (metric.descriptor.valueType === apiValueType.DOUBLE) {
     doubleDataPoints = [points];
-  }
+  } // @TODO: Implement support for histogram/distribution points
 
   return {
     metricDescriptor: toCollectorMetricDescriptor(metric),