Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temperature validation in deye_p3.yaml #405

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

piohei
Copy link
Contributor

@piohei piohei commented Feb 11, 2025

It's not common probably but my batteries are outside the heated zone and can get with temp below zero. From Deye specification temp values can also be below 0. This change fixes valid ranges. I've tested this in my setup and all works.

@davidrapan
Copy link
Owner

davidrapan commented Feb 11, 2025

Hi @piohei, great point! But because -100 is placeholder value for some faulty behaviors I'd set -99 as min and you should not forget that it's value w/ offset: 1000 so -99 will be min: 901

Edit: range: changes are not neccasary. validation: was causing you the issues so change just those. 😉

Edit2: range: is before applying the offset and validation: is after (for clarification).

Thanks!

@piohei piohei force-pushed the piohei/fix_deye_temp branch from 8724555 to 2a87729 Compare February 11, 2025 09:50
@piohei
Copy link
Contributor Author

piohei commented Feb 11, 2025

yeah....good point :) Changed only validation min to -99.

@davidrapan
Copy link
Owner

davidrapan commented Feb 11, 2025

Can you also extend the changes to the single-phase profile? Thanks!

Edit: And I guess also include other temperature sensors as well as those in micro and string profiles...

👍

@piohei
Copy link
Contributor Author

piohei commented Feb 11, 2025

I've checked all other configurations (not only for deye) but they do not have set validation for any temp measurements. This is set only in deye_p3.yaml.

@davidrapan
Copy link
Owner

Ahhh, okay then! 👍

@davidrapan davidrapan changed the title Fix min temperature for deye_p3.yaml. Fix temperature validation in deye_p3.yaml Feb 11, 2025
@davidrapan davidrapan merged commit c6985a2 into davidrapan:main Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants