Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove default model from the language model options #498

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

davidmigloz
Copy link
Owner

@davidmigloz davidmigloz commented Jul 20, 2024

Resolves #481

LanguageModelOptions (like ChatOpenAIOptions, ChatMistralAIOptions etc) do not specify the default model in the constructor anymore. Instead, the default model is applied if the model field in defaultOptions and the invoke options are null. This prevents the model to be reset when using the bind operator.

@davidmigloz davidmigloz self-assigned this Jul 20, 2024
@davidmigloz davidmigloz added p:langchain_openai langchain_openai package. p:langchain_google langchain_google package. p:langchain_ollama langchain_ollama package. p:langchain_mistralai langchain_mistralai package. p:langchain_firebase langchain_firebase package. p:langchain_anthropic langchain_anthropic package labels Jul 20, 2024
@davidmigloz davidmigloz added this to the v0.8.0 milestone Jul 20, 2024
@davidmigloz davidmigloz merged commit 44363e4 into main Jul 20, 2024
1 check passed
@davidmigloz davidmigloz deleted the 481 branch July 20, 2024 14:33
KennethKnudsen97 pushed a commit to KennethKnudsen97/langchain_dart that referenced this pull request Oct 1, 2024
KennethKnudsen97 pushed a commit to KennethKnudsen97/langchain_dart that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:langchain_anthropic langchain_anthropic package p:langchain_firebase langchain_firebase package. p:langchain_google langchain_google package. p:langchain_mistralai langchain_mistralai package. p:langchain_ollama langchain_ollama package. p:langchain_openai langchain_openai package.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make LanguageModelOptions (like ChatOpenAIOptions) more bind-friendly
1 participant