Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for listing running Ollama models #451

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add support for listing running Ollama models #451

merged 2 commits into from
Jun 13, 2024

Conversation

HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Jun 5, 2024

No description provided.

@davidmigloz
Copy link
Owner

Thanks for the PR @HavenDV!
I'll review it this weekend

@davidmigloz davidmigloz self-requested a review June 7, 2024 15:26
@davidmigloz davidmigloz added t:enhancement New feature or request p:ollama_dart ollama_dart package. labels Jun 7, 2024
@davidmigloz davidmigloz added this to the v0.8.0 milestone Jun 7, 2024
davidmigloz
davidmigloz reviewed Jun 13, 2024
View reviewed changes
packages/ollama_dart/oas/ollama-curated.yaml Outdated
enum:
- stop # The generation hit a stop token.
- length # The maximum num_tokens was reached.
- load # The request was sent with an empty body to load the model.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep it as an enum, otherwise it makes it more cumbersome to get the actual value.
I don't expect these values to change much. And if they do change, the client won't crash, it will just return null for the new type until it is added to the list.

packages/ollama_dart/oas/ollama-curated.yaml Outdated
enum:
- creating system layer
- parsing modelfile
- success
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

packages/ollama_dart/oas/ollama-curated.yaml Outdated
anyOf:
- type: string
- type: string
enum:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

packages/ollama_dart/oas/ollama-curated.yaml Outdated
anyOf:
- type: string
- type: string
enum:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and same here

@davidmigloz
Copy link
Owner

I've made some minor changes that address some of the comments. I'll merge it for now to add support for listRunningModels. Thanks again for the PR!

@davidmigloz davidmigloz merged commit cfaa31f into davidmigloz:main Jun 13, 2024
1 check passed
@davidmigloz davidmigloz changed the title Update ollama-curated.yaml Add support for listing running Ollama models Jun 13, 2024
@HavenDV HavenDV deleted the patch-1 branch June 13, 2024 10:12
@HavenDV
Copy link
Contributor Author

HavenDV commented Jun 13, 2024

Regarding AnyOf - I did the same as it is done in the OpenAI OpenAPI specification, this will allow users to be able to access new values ​​from the SDK without the need to update, and also makes it possible to do more correct logging of what is happening because there are values ​​like this (for PullModel)
image

KennethKnudsen97 pushed a commit to KennethKnudsen97/langchain_dart that referenced this pull request Oct 1, 2024
@HavenDV @davidmigloz @KennethKnudsen97
feat: Add support for listing running Ollama models (davidmigloz#451)
45b1a22 
Co-authored-by: David Miguel <me@davidmiguel.com>
KennethKnudsen97 pushed a commit to KennethKnudsen97/langchain_dart that referenced this pull request Oct 1, 2024
@HavenDV @davidmigloz @KennethKnudsen97
feat: Add support for listing running Ollama models (davidmigloz#451)
6149566 
Co-authored-by: David Miguel <me@davidmiguel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmigloz davidmigloz davidmigloz left review comments

Assignees

@HavenDV HavenDV

Labels
p:ollama_dart ollama_dart package. t:enhancement New feature or request
Projects
LangChain.dart
Status: ✅ Done
Milestone
v0.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@HavenDV @davidmigloz