Make the box-sizing explicit on the MoonLoader circle #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of Tailwind CSS force everything to `box-sizing: border-box;` (see tailwindlabs/tailwindcss#1111 ) Tailwind isn't the only thing out there using that hack, so this is sure to be a wider-ranging problem. The result of using Tailwind & react-spinners in the same project without this change is that the spinner circle wobbles around.
|
hi @maco, what effect does adding this have on the loader when |
|
Content-box is the default in all non-Microsoft browsers and in Microsoft
ones after…IE9, IIRC. Your code expects the browsers to be doing their
default thing. Tailwind is behaving like a reset rule.
--
Mackenzie Morgan
(she/her)
|
|
ah i see. @maco thanks for the change. I'll review once i get a chance to. Can you also update snapshots? Otherwise the tests will fail. |
|
would love to see this in master. You cant override this using the override method from the docs so it becomes troublesome to fix. Right now im using a css wildcard which is far less than ideal: |
|
I checked out the changes. looks good for all browsers. |
davidhu2000
approved these changes
May 2, 2020
davidhu2000
added a commit
that referenced
this pull request
May 2, 2020
|
This is released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of Tailwind CSS force everything to
box-sizing: border-box;(see tailwindlabs/tailwindcss#1111 )
Tailwind isn't the only thing out there using that hack, so this is sure to be a wider-ranging problem.
The result of using Tailwind & react-spinners in the same project without this change is that the spinner circle wobbles around.