Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya Tool - Remove All mmSolver Nodes from Scene #76

Closed
david-cattermole opened this issue Mar 31, 2019 · 6 comments
Closed

Maya Tool - Remove All mmSolver Nodes from Scene #76

david-cattermole opened this issue Mar 31, 2019 · 6 comments
Assignees
Labels
Milestone

Comments

@david-cattermole
Copy link
Owner

Create a tool to clean up and delete all mmSolver specific nodes.
This will help users needing to send files to other users that do not have mmSolver.

Usage:

  1. Open Maya scene with mmSolver
  2. Run tool (on the mmSolver shelf)
  3. All nodes specific to mmSolver are removed and the plug-in unloaded.

When working in a GUI environment and a "force=True" keyword argument is not passed, a pop-up dialog should be presented saying "Are you sure?".

This tool / function should be executable without a Maya GUI open (such as inside mayapy).

@david-cattermole
Copy link
Owner Author

It may also be helpful to create a user interface for this tool.
A user may wish to remove all nodes related to mmSolver, not just custom nodes.

We could create a window to allow deleting the following categories in a Maya scene file.

  • Markers
  • Bundles
  • Marker Groups (and Markers)
  • Collections

This GUI would be a "clean up" tool. The primary use for this tool is to allow clean up of a Maya scene before giving the the Maya file to another person, who may no have mmSolver installed.

We may need to consider how nodes connected or parented under marker groups, or bundles should be handled. For example, a parented node should be unparented and baked into world space.

@ktonegawa
Copy link
Contributor

Hi David, I created a Pull request from my forked repo as to start a conversation...

ktonegawa added a commit to ktonegawa/mayaMatchMoveSolver that referenced this issue Dec 16, 2020
@david-cattermole
Copy link
Owner Author

Hello @ktonegawa,

Thanks for your PR, it has been merged into the master branch, and will be released in the next version.

Would you like to write some user documentation for the tool? If not, I can probably write it in the next few days.

Meanwhile I have added your name to the AUTHORS.txt file and copyrights, so your name is on the website:
https://david-cattermole.github.io/mayaMatchMoveSolver/#authors
(might take a little while to build and update)

@ktonegawa
Copy link
Contributor

Thank you @david-cattermole for merging the PR so fast! I was going to address your note about creating a lib.py and porting over the functions, if you would still like me to do this please let me know!

Yes I would love to take a crack at the documentation portion. Should I just try adding a section into the tools.html page...?

@david-cattermole
Copy link
Owner Author

I was going to address your note about creating a lib.py and porting over the functions, if you would still like me to do this please let me know!

If you want to, go ahead, but I don't think it's needed.

Yes I would love to take a crack at the documentation portion. Should I just try adding a section into the tools.html page...?

You don't edit the tools.html file directly, because it is auto-generated with Sphinx.

Instead, you should edit this file:
https://github.com/david-cattermole/mayaMatchMoveSolver/blob/master/docs/source/tools_generaltools.rst

Annoyingly, I cannot show you the actual code for that file via GitHub because GitHub is automatically rendering it into HTML.
You should probably add a new heading between "Reparent Under Node" and "Sort Selected Nodes In Outliner" because that is where you've placed your menu.

For future reference, I have added the sphinx auto-generated documentation in commit 6b488ac so you can see what I have changed.

@david-cattermole
Copy link
Owner Author

There has been some documentation added in PR #189.

The documentation is uploaded:
https://david-cattermole.github.io/mayaMatchMoveSolver/tools_generaltools.html#remove-solver-nodes
... and here,
https://david-cattermole.github.io/mayaMatchMoveSolver/mmSolver.tools.removesolvernodes.html

I think we can close this issue now, if there's a problem we'll open a new issue.

Thanks @ktonegawa!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants