Make getAsSelectionList string parameter referenced.

... not copied by value, which will be expensive for a MString object.
david-cattermole · Dec 31, 2022 · d7a4289 · d7a4289
1 parent c82be0b
commit d7a4289
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/mmSolver/mayahelper/maya_utils.cpp b/src/mmSolver/mayahelper/maya_utils.cpp
@@ -70,7 +70,7 @@ MStatus getAsSelectionList(const MStringArray &nodeNames,
     return status;
 }
 
-MStatus getAsSelectionList(const MString nodeName, MSelectionList &selList) {
+MStatus getAsSelectionList(const MString &nodeName, MSelectionList &selList) {
     MStringArray nodeNames;
     nodeNames.append(nodeName);
     return getAsSelectionList(nodeNames, selList);

diff --git a/src/mmSolver/mayahelper/maya_utils.h b/src/mmSolver/mayahelper/maya_utils.h
@@ -76,7 +76,7 @@ enum class ObjectType {
 MStatus getAsSelectionList(const MStringArray &nodeNames,
                            MSelectionList &selList);
 
-MStatus getAsSelectionList(const MString nodeName, MSelectionList &selList);
+MStatus getAsSelectionList(const MString &nodeName, MSelectionList &selList);
 
 MStatus nodeExistsAndIsType(const MString &nodeName, const MFn::Type nodeType);