Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign tests + 3.0 support #304

Merged
merged 2 commits into from
Feb 13, 2021
Merged

Redesign tests + 3.0 support #304

merged 2 commits into from
Feb 13, 2021

Conversation

davetron5000
Copy link
Owner

This adds support for Ruby 3.0 by removing Aruba and reorganizing the tests. Namely:

  • Matrixed build on Circle CI against all supported MRI Rubies
  • All tests ported to Minitest and modernized/simplified
  • Clean Test and all that is removed
  • Aruba and Cucumber is gone and replaced with much simpler integration tests. These don't cover GLI quite as well, but given that everything has been working, I'll add more coverage when bugs are addressed or features are added. The pain of keeping them working over the years is not worth it
  • The scaffolding removes cucumber and is slightly better, but still kinda crappy
  • Moved gli to exe/gli to be consistent with new Bundler conventions

@davetron5000 davetron5000 merged commit 352a3a0 into main Feb 13, 2021
@davetron5000 davetron5000 deleted the redesign-tests branch February 13, 2021 22:39
@davetron5000 davetron5000 mentioned this pull request Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant