Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ScriptFiles item group name to ScriptyFiles #6

Closed
daveaglick opened this issue Jun 7, 2016 · 5 comments
Closed

Change ScriptFiles item group name to ScriptyFiles #6

daveaglick opened this issue Jun 7, 2016 · 5 comments

Comments

@daveaglick
Copy link
Owner

This will avoid collisions given the name is overly generic

@wgebczyk
Copy link

wgebczyk commented Jun 9, 2016

usually Item names are singular. You might consider to use "ScriptyFile"

@daveaglick
Copy link
Owner Author

@wgebczyk In this case, it's the name of an ItemGroup element in the MSBuild target that gets passed into a property in the MSBuild task. Since the property is intended to take a collection, it probably makes sense to pluralize the element name too so they match.

@wgebczyk
Copy link

wgebczyk commented Jun 9, 2016

Hmm... Like multiple "Reference", "ProjectReference", "Compile", "Page", "Resource", "Content", etc...

  • your tool, your naming :)

@daveaglick
Copy link
Owner Author

@wgebczyk Ah, see your point! Indeed, all those elements can take single or multiple includes... No naming issue is too small to deliberate 😄 - I'll give this one a little thought.

@crash-dive
Copy link
Contributor

crash-dive commented Apr 14, 2017

@daveaglick The docs on the main page were not updated to reflect this change. It still reads

<ScriptFiles Include="codegen.csx" /> 

which caused me some confusion.

Thanks for the tool, it is a lot easier than T4 has been.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants