Dataset versions API #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions # Conflicts: # ckanext/versions/model.py
|
@pdelboca It's been a while and my team managed to get a working feature for dataset versions for our client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Introduce versioning at the dataset level.
Details:
Current implementation is oriented around creating versions for resources. My project needs versions created in the scope of a dataset (all resources versioned as one entity).
Currently
model.Versionacceptsresource_idas optional which makes it perfectly usable for this new approach. Also many version actions are "resource id agnostic" (update, delete, list).Problem:
Some actions however explicitly mentions scope of the resource, e.g.
resource_version_create,resource_version_current, etc. which makes it quite hard to use current API to fulfill my needs.Proposed solution:
Extend the actions of
ckanext-versionswith a set of endpoints for versions in dataset scope. This PR presents only action functions stubs and set of functional tests to better describe what I want to achieve.From my perspective it'd be best to have this work as a core part of this extension. If so I could avoid forking it and spending time updating it with latest changes from the origin :)
@pdelboca I would welcome your feedback at this early stage if this work might be accepted at all. I am also happy to change my design if you see fit. Thanks in advance!