Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we are always using the same token setting for datapusher #168

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

avdata99
Copy link
Contributor

It's not clear which token setting is required

This PR:

  • Moves all references to the util get_dp_plus_user_apitoken
  • Preserve the default ckan.datapusher.api_token and aldo continues using the new setting ckan.datapusher_plus.api_token

I'm not sure which one we expect to use.

Also:

  • Small code changes to clean unused imports

@tino097 tino097 merged commit 55fe97a into dathere:dev-v1.0 Sep 23, 2024
@tino097
Copy link
Collaborator

tino097 commented Sep 23, 2024

Thanks @avdata99

@tino097
Copy link
Collaborator

tino097 commented Oct 23, 2024

hey @avdata99 i've just noticed that you have ckan.datapusher_plus.api_token but in the config declaration we have set all the config variables as ckanext.datapusher_plus.*** . Not sure why didnt complain

@avdata99
Copy link
Contributor Author

I think it was before this change @tino097 3152328
In the future we will only use the new setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants