Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datefmt command on newer qsv and update the minimum version #160

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

Zharktas
Copy link
Contributor

Fixes #141

Since datefmt moved to its own command in qsv 0.123, updates the minimum version to match it.

Copy link
Collaborator

@tino097 tino097 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tino097
Copy link
Collaborator

tino097 commented Aug 22, 2024

Thanks @Zharktas

Can you please make same PR against dev-v1.0 branch ?

And if you have time, can you do some testing ?

@Zharktas
Copy link
Contributor Author

Can you please make same PR against dev-v1.0 branch ?

done

And if you have time, can you do some testing ?

I'll probably have time next month :)

@tino097 tino097 merged commit 7c79cb8 into dathere:master Aug 23, 2024
2 checks passed
avdata99 added a commit to avdata99/datapusher-plus that referenced this pull request Sep 20, 2024
After dathere#160 I think we need to point QSV to 0.123
@avdata99 avdata99 mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer_dmy failing
2 participants