Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete assets #159

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

pdelboca
Copy link
Contributor

@pdelboca pdelboca commented Aug 20, 2024

This will fix #158 .

datapusher-plus:dev-v1.0 does no longer ship with webassets, so there is no need to call for them.

Let me know if you have other plans and I'm happy to create a new PR.

@tino097
Copy link
Collaborator

tino097 commented Aug 23, 2024

Hey @pdelboca if we will remove the datapusher from core maybe its good to move assets in DP+, so maybe we could keep this for a while ?

@pdelboca
Copy link
Contributor Author

@tino097 that sounds like an option! What are those assets for though?

Currently, this works only if you have datapusher_plus and datapusher in your ckan.plugins. Is that the expected current setup?

@tino097
Copy link
Collaborator

tino097 commented Aug 24, 2024

@pdelboca Yeah, this probably was merged by mistake, when i was trying to implement the core datapusher into datapusher_plus

I will merge this PR and we would reimport the assets when the time will come

@tino097 tino097 merged commit dc5c8b0 into dathere:dev-v1.0 Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants