Fixes #8: Migrate code base to TypeScript #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although, to be fair, manually importing from package files instead of the package itself is kind of like using private APIs and you really have to expect that to break in future versions. Eh, anyway. |
zner0L
requested changes
Mar 25, 2022
| // The `marginTop` is missing in the type definitions. | ||
| type PdfMakeSignature = (ContentText | ContentImage) & { marginTop: number }; | ||
|
|
||
| const _parseTags = (content: string) => { |
There was a problem hiding this comment.
Anything wrong with the inferred type? Looks fine to me.
There was a problem hiding this comment.
I like the code to be expressive actually.
| } | ||
|
|
||
| /** Render the letter as a string, used e.g. for emails. */ | ||
| toString() { |
There was a problem hiding this comment.
This also (even though it is obvious).
There was a problem hiding this comment.
Same here. TS infers string just fine. I'm not a big fan of being unnecessarily explicit with types when TS can infer them correctly.
This results in a (slight) external API change:
`website` previously did imports like this:
```js
import { formatAddress, stripTags } from 'letter-generator/utility';
import Letter from 'letter-generator/Letter';
import Template from 'letter-generator/Template';
```
We don't support that anymore, you now need to import like this:
```js
import { Letter, Template, formatAddress, stripTags }
from 'letter-generator';
```
So, I think it would make sense to start a new major version for this.
8ce4492 to
eb2cb55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in a (slight) external API change:
websitepreviously did imports like this:We don't support that anymore, you now need to import like this:
So, I think it would make sense to start a new major version for this.