Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix huge signature #12

Closed
baltpeter opened this issue May 24, 2022 · 0 comments
Closed

Fix huge signature #12

baltpeter opened this issue May 24, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@baltpeter
Copy link
Member

baltpeter commented May 24, 2022 •
edited
Loading

datenanfragen/website#874 (comment)
@baltpeter baltpeter added the bug Something isn't working label May 24, 2022
@baltpeter baltpeter mentioned this issue May 24, 2022
Merged
@baltpeter baltpeter mentioned this issue Oct 26, 2022
Open
33 tasks
baltpeter added a commit that referenced this issue Nov 17, 2022
@baltpeter
Fixes #12: Give signature image a maxWidth
76e8b5c 
The problem of the huge signature was caused by #3. Removing the fixed
`width` from the signature caused the image to scale to the page width
(even though the docs say this should mean the image's original size
*shrug*).

Instead, we now set a `maxWidth`, which solves both problems. I haven't
actually found any documentation for this feature but it was implemented
in bpampuch/pdfmake#938.
@zner0L zner0L closed this as completed in fb878a4 Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baltpeter