Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make _kind and _api_version to be optional #164

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

yusukefs
Copy link
Contributor

What?

Make _kind and _api_version to be optional in schemas.

Why?

To solve error on validating api response when _kind or _api_version is absent.

@yusukefs yusukefs requested a review from d-hayashi June 28, 2023 00:58
Copy link
Contributor

@d-hayashi d-hayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukefs yusukefs merged commit 2249c5e into master Jun 28, 2023
@yusukefs yusukefs deleted the feat/make-kind-and-api_version-optional branch June 28, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants