Use django-style logging support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The package defined its own root logger and this constrained (unnecessarily) the useage by third parties. Solution: Added module-named loggers at each endpoint to allow ultimate flexibility in configuring logging by the user. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
JAG-UK
reviewed
Jun 28, 2021
JAG-UK
approved these changes
Jun 28, 2021
eccles
added a commit
that referenced
this pull request
Mar 22, 2022
Problem: The package defined its own root logger and this constrained (unnecessarily) the useage by third parties. Solution: Added module-named loggers at each endpoint to allow ultimate flexibility in configuring logging by the user. Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The package defined its own root logger and this constrained
(unnecessarily) the useage by third parties.
Solution:
Added module-named loggers at each endpoint to allow ultimate
flexibility in configuring logging by the user.
Signed-off-by: Paul Hewlett phewlett76@gmail.com