This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
[PRED-2150] fix verify_ssl argument in api token retrieve #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aafe34e to
7a06efd
Compare
|
LGTM please add your change to https://github.com/datarobot/batch-scoring/blob/master/CHANGES.rst and then lets release this! |
pprett
previously approved these changes
Dec 17, 2018
|
See https://github.com/datarobot/batch-scoring/blob/master/DEV_README.rst#release for the release process |
|
Thanks @pprett! |
1 similar comment
Axik
previously approved these changes
Dec 17, 2018
CHANGES.rst
Outdated
| 1.15.2 (2018 Dec 17) | ||
| ===================== | ||
|
|
||
| Enhancements |
There was a problem hiding this comment.
This is bugfix, not an enhancement :)
Axik
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BATCH SCORING PULL REQUEST
This is a pull request into a public repository for Batch Scoring script maintained by DataRobot.
RATIONAL
We fail to use the verify argument in the request to get the user's api token. This means that if SSL is enabled, the request to get the API token will fail. This should fix that.