Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Update trafaret dependencies to be compatible with datarobot-sdk #145

Merged
merged 2 commits into from
Dec 4, 2018

Conversation

pprett
Copy link
Contributor

@pprett pprett commented Dec 4, 2018

BATCH SCORING PULL REQUEST

This is a pull request into a public repository for Batch Scoring script maintained by DataRobot.

RATIONALE

t.String(regex=...) has been deprecated in newer versions of trafaret in favor of https://trafaret.readthedocs.io/en/latest/intro.html#regexp .

CHANGES

Changed t.String(regex=... to t.Regexp(regexp=... and updated requirements to match datarobot-sdk trafaret>=0.7,<2.0,!=1.1.0

TESTING

@pprett pprett requested review from Axik and nimnull December 4, 2018 09:09
Copy link
Contributor

@Axik Axik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Axik Axik merged commit 888a2c5 into master Dec 4, 2018
@pprett pprett deleted the peter/PRED-2146 branch December 4, 2018 16:10
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.949% when pulling c1ab6ec on peter/PRED-2146 into be4224a on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.949% when pulling 3892f8a on peter/PRED-2146 into be4224a on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants