Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest/databricks): ingest hive metastore by default, more docs #9601

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Jan 10, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 10, 2024
@@ -135,7 +135,7 @@ class UnityCatalogSourceConfig(
)

include_metastore: bool = pydantic.Field(
default=True,
default=False,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's call out that this is a breaking change?

It might also be good to show examples of what the hierarchy would look like when this is true/false

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we should say we recommend keeping this set to false, and that folks should use platform_instance instead

Copy link
Collaborator Author

@mayurinehate mayurinehate Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the section in doc about hierarchy + update description of include_metastore config field.

As far as I understand, we'll get rid of this config, eventually. So the section would not be relevant - post that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. added in updating-datahub.md as a breaking change
  2. added the examples in updating-datahub doc, I believe, you meant this only and not to add this in source docs ?
  3. we already have pydantic validator for warning if this is not set to false, so we are covered there. changed the error message to represent current state.

mayurinehate and others added 2 commits January 11, 2024 15:22
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
@hsheth2 hsheth2 merged commit f2e78db into datahub-project:master Jan 18, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants