feat(sqlparser): support more update syntaxes + fix bug with subqueries #9105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asikowitz
approved these changes
Oct 30, 2023
| # Update statements always implicitly have the updated table in context. | ||
| # TODO: Retain table name alias. | ||
| if select_statement.args.get("from"): | ||
| # select_statement = sqlglot.parse_one(select_statement.sql(dialect=dialect)) |
There was a problem hiding this comment.
will do in a follow-up
There was a problem hiding this comment.
done in here 87d0b06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles more edge cases in
UPDATEstatement CLL, and also fixes a bug with our generation of CLL of subqueries (we'd previously miss some columns, and also generate some incorrect lineage).Adds test cases related to those, and also checked that this has no negative impact with our private query corpus. For some queries that we don't handle correctly right now, I've also added test cases in skip mode so that we can turn them on once we get them to work properly.
Checklist