Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(versioning): Add V2 UI; make backend more synchronous; add to component library #12542

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Feb 3, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 3, 2025
@RyanHolstien RyanHolstien changed the title feat(verisioning): Add V2 UI; make backend more synchronous feat(versioning): Add V2 UI; make backend more synchronous Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 65.22327% with 1028 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...omponents/components/Select/AutoCompleteSelect.tsx 29.20% 160 Missing ⚠️
.../app/entityV2/shared/versioning/VersionsDrawer.tsx 43.11% 128 Missing ⚠️
...ntityDropdown/versioning/LinkAssetVersionModal.tsx 19.17% 118 Missing ⚠️
...app/entityV2/shared/versioning/VersionsPreview.tsx 49.67% 77 Missing ⚠️
.../entityV2/shared/EntityDropdown/EntityDropdown.tsx 17.33% 62 Missing ⚠️
...2/shared/EntitySearchInput/EntitySearchInputV2.tsx 30.12% 58 Missing ⚠️
.../src/alchemy-components/components/Modal/Modal.tsx 55.55% 52 Missing ⚠️
...n/src/datahub/ingestion/graph/entity_versioning.py 25.39% 47 Missing ⚠️
...ityDropdown/versioning/UnlinkAssetVersionModal.tsx 26.22% 45 Missing ⚠️
...t/src/alchemy-components/components/Pills/utils.ts 25.86% 43 Missing ⚠️
... and 35 more

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
...t/src/alchemy-components/components/Badge/utils.ts 20.00% <100.00%> (ø)
...alchemy-components/components/Button/components.ts 100.00% <100.00%> (ø)
...ct/src/alchemy-components/components/Icon/Icon.tsx 89.83% <100.00%> (ø)
...rc/alchemy-components/components/Icon/constants.ts 100.00% <100.00%> (ø)
...ct/src/alchemy-components/components/Icon/index.ts 100.00% <100.00%> (ø)
...ct/src/alchemy-components/components/Icon/utils.ts 100.00% <100.00%> (ø)
...t/src/alchemy-components/components/Modal/index.ts 100.00% <100.00%> (ø)
.../alchemy-components/components/Pills/components.ts 100.00% <100.00%> (ø)
...chemy-components/components/Tooltip2/components.ts 100.00% <100.00%> (ø)
datahub-web-react/src/alchemy-components/index.ts 100.00% <100.00%> (ø)
... and 60 more

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469cc4f...97acaac. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 3, 2025
@asikowitz asikowitz changed the title feat(versioning): Add V2 UI; make backend more synchronous feat(versioning): Add V2 UI; make backend more synchronous; add to component library Feb 3, 2025
@asikowitz asikowitz merged commit b51327e into datahub-project:master Feb 4, 2025
194 of 200 checks passed
@asikowitz asikowitz deleted the versioning-updates branch February 4, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants