Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/azure-ad): limit the size of the ingestion report #12498

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 30, 2025

Replaces list with a LossyList. Also removes the filtered_tracking flag - it remains the default. This is in-line with how the rest of our sources track filtered/ignored objects.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Also removes the `filtered_tracking` flag - it remains the default. This
is in-line with how the rest of our sources track filtered/ignored objects.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/datahub/ingestion/source/identity/azure_ad.py 83.33% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
.../src/datahub/ingestion/source/identity/azure_ad.py 78.37% <83.33%> (+0.60%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280e82a...2b0a85b. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 30, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 31, 2025
@hsheth2 hsheth2 merged commit 1e0f993 into master Jan 31, 2025
217 of 247 checks passed
@hsheth2 hsheth2 deleted the azure-ad-limit-report branch January 31, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants