Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion/dbt): Add database and schema filtering to dbt #12489

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jackson-burke
Copy link

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

This feature allows for filtering of nodes included based on database and/or schema, in addition to the node name filtering that is allowed now.

As an example, from the dbt_manifest.json:

"source.sample_dbt.pagila.payment_p2020_05": {
    // ... other properties omitted ...
    "database": "pagila",
    // ... other properties omitted ...
    "schema": "public"
    // ... other properties omitted ...
}

We could now provide "public" in the schema_name_pattern to either include or exclude this node, and others in the "public" schema.

Somewhat related to #12411.

@jackson-burke jackson-burke changed the title Feat(ingestion/dbt): Add database and schema filtering to dbt feat(ingestion/dbt): Add database and schema filtering to dbt Jan 29, 2025
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 29, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...app/ingest/source/builder/RecipeForm/dbt_cloud.tsx 84.80% <100.00%> (+2.78%) ⬆️
...ion/src/datahub/ingestion/source/dbt/dbt_common.py 91.19% <100.00%> (-0.33%) ⬇️

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47134c2...43e2c93. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant