Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion/classifier): Fix classifier parallelism #12485

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(ingestion/classifier): Fix classifier parallelism #12485

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
908f4f0
Initial approach to fixing parallelism
skrydal Jan 28, 2025
667eca9
Revert "Initial approach to fixing parallelism"
skrydal Jan 28, 2025
c6effcd
The simplest fix
skrydal Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions metadata-ingestion/src/datahub/utilities/partition_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from __future__ import annotations

import atexit
import collections
import functools
import logging
Expand Down Expand Up @@ -220,10 +219,10 @@ def _shutdown_executors() -> None:
# This entire shutdown hook is largely a backstop mechanism to protect against
# improper usage of the BatchPartitionExecutor. In proper usage that uses
# a context manager or calls shutdown() explicitly, this will be a no-op.
if hasattr(threading, "_register_atexit"):
threading._register_atexit(_shutdown_executors)
else:
atexit.register(_shutdown_executors)
# if hasattr(threading, "_register_atexit"):
# threading._register_atexit(_shutdown_executors)
# else:
# atexit.register(_shutdown_executors)


class BatchPartitionExecutor(Closeable):
Expand Down
Loading