Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): adds missing containers and browsepathsv2 for dataflow and datajob #12483

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Jan 28, 2025

This is a new attempt that builds on top of PR #12194

Main difference is in previous attempt all dataflow/jobs were at database level, however in the new attemp datajobs representing stored procedures are placed at schema level (as can be seen in second screenshot).

Testing by ingesting one of the updated golden files:

$ datahub ingest mcps /Users/sergio/workspace/github/datahub-project/datahub/metadata-ingestion/tests/integration/sql_server/golden_files/golden_mces_mssql_to_file.json
Screenshot 2025-01-28 at 17 00 51 Screenshot 2025-01-28 at 17 01 17

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 28, 2025
@sgomezvillamor sgomezvillamor marked this pull request as ready for review January 28, 2025 16:02
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
...c/datahub/ingestion/source/sql/mssql/job_models.py 97.04% <100.00%> (+0.18%) ⬆️
...n/src/datahub/ingestion/source/sql/mssql/source.py 89.09% <100.00%> (+0.06%) ⬆️

... and 1349 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d091fff...1905341. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants