Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/unity): add row count in table profile of delta tables #12480

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 28, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../src/datahub/ingestion/source/unity/ge_profiler.py 7.14% 13 Missing ⚠️

❌ Your patch check has failed because the patch coverage (7.14%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
...rc/datahub/ingestion/source/ge_profiling_config.py 97.33% <ø> (ø)
.../src/datahub/ingestion/source/unity/ge_profiler.py 27.45% <7.14%> (-3.24%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 563656c...007ab22. Read the comment docs.

mayurinehate and others added 2 commits January 28, 2025 22:20
…onfig.py

Co-authored-by: Sergio Gómez Villamor <sgomezvillamor@gmail.com>
…onfig.py

Co-authored-by: Sergio Gómez Villamor <sgomezvillamor@gmail.com>
@mayurinehate mayurinehate changed the title fix(ingest/unity): table level profile of large delta tables fix(ingest/unity): add row count in table profile of delta tables Jan 28, 2025
Comment on lines +151 to +152
# Presence of size_in_bytes confirms this is DELTA table and that we have
# SELECT permission on this table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we may transform this comment in actual code. Something like:

is_delta_table = table.size_in_bytes is not None

and then use the new flag accordingly to call delta-specific code

WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we can add is_delta_table boolean in UnityCatalogSQLGenericTable based on custom property data_source_format in original table.
Or we can add is_delta_table_with_select_enabled: table.size_in_bytes is not None as suggested. Maybe I can do both.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants