-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): data process instance - container, subtype, dataplatformin… #12476
feat(sdk): data process instance - container, subtype, dataplatformin… #12476
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (67.74%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
try: | ||
# We first try to create from string assuming its an urn | ||
self._platform = str(DataPlatformUrn.from_string(self._platform)) | ||
except Exception: | ||
# If it fails, we assume its an id | ||
self._platform = str(DataPlatformUrn(self._platform)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope, but we should have a helper method for this sort of logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to test specifying data_platform_instance, subtype, and container in test_basic_initialization
, think that would pass codecov
…stance support
Checklist