-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire up flags and user preferences for theme v2 #12475
Closed
chriscollins3456
wants to merge
1
commit into
datahub-project:master
from
chriscollins3456:cc--alchemy-ui-test
Closed
wire up flags and user preferences for theme v2 #12475
chriscollins3456
wants to merge
1
commit into
datahub-project:master
from
chriscollins3456:cc--alchemy-ui-test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update app providers, protexted routes, constant, and fix urn mapper add homeV2 and sharedV2 add configV2 add entityV2 add searchV2 add previewV2 add settingsV2 add lineageV2 add glossaryV2 add domainV2 work through as many bad references etc. deleting things and adding things that needed to be added. UI now opens, but stuck on introduce page. update SearchRoutes.tsx to point to v2 pages remove platform folder and add a few missing svgs remove majority of inferred documentation stuff. still some references there though clean up more isInferred and other linting issues remove documentation forms flag check make es lint rules consistent for no cycles remove metadata sharing feature fix broken glass preventing UI from coming up fix global styles and look add connection to entity profile page V2 and resolve a good chunk of dependency failures that ensued deal with a large amount of the build time errors. updated graphql on the client side and get errors. created ticket CH-196 for it remove stats tab v2. can bring back once it's done remove reference to lineagefeatures add siblings search capabilities on the BE add BE functionality for display properties add schema field status remove fields on query fragment that didn't exist in backend. update alchemy-components to be consistent with saas remove v2 governance tab, update broken graphql files to match saas clean up the Validations folder for observability to work in OSS support siblingsSearch in the UI fix lint before removing auto-generated files and rebuilding fix up linting after removing auto-gen graphql files, main blocking ones are new features for their own commits add timeline.graphql and the timeline feature remove custom name/icon and custom help link remove chunk of linting issues from missing/wrong impl fix another chunk of linting issues to get below 100 remove some more linting issues before tackling specific features one at a time fix(web) correctly determine if on siblings page datahub-project#4987 implement the replacement feature on deprecation update entity privileges to include new checks implement full size search card view implement entity notes feature remove rest of proposals references return chrome extension config, update list queries input/resolver, fix a few linting issues add lineage feature flags make some more changes to assertions to remove refs to monitors add more events, fix a few more linting issues add more flags and events and clean up more linting finish linting issues except for observe stuff fix up frontend tests failing get nav bar redesign wired up add additional styles for nav bar redesign remove duplicate entry in entity type urn mapper fix bugs from cypress test and cypress tests themselves get linting totally clean fix lint in cypress update assertion.graphql to fix bug with opening assertion drawer add back share menu for copying urns and what not in the UI fix onboarding tour and storing v2 and nav bar redesign flags in local storage properly add missed references to useIsThemeV2 add V2 cypress tests fix bug with onboarding tour caught by cypress tests add features tab to v2 settings
github-actions
bot
added
product
PR or Issue related to the DataHub UI/UX
devops
PR or Issue related to DataHub backend & deployment
smoke_test
Contains changes related to smoke tests
labels
Jan 28, 2025
datahub-cyborg
bot
added
the
needs-review
Label for PRs that need review from a maintainer.
label
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
PR or Issue related to DataHub backend & deployment
needs-review
Label for PRs that need review from a maintainer.
product
PR or Issue related to the DataHub UI/UX
smoke_test
Contains changes related to smoke tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update app providers, protexted routes, constant, and fix urn mapper
add homeV2 and sharedV2
add configV2
add entityV2
add searchV2
add previewV2
add settingsV2
add lineageV2
add glossaryV2
add domainV2
work through as many bad references etc. deleting things and adding things that needed to be added. UI now opens, but stuck on introduce page.
update SearchRoutes.tsx to point to v2 pages
remove platform folder and add a few missing svgs
remove majority of inferred documentation stuff. still some references there though
clean up more isInferred and other linting issues
remove documentation forms flag check
make es lint rules consistent for no cycles
remove metadata sharing feature
fix broken glass preventing UI from coming up
fix global styles and look
add connection to entity profile page V2 and resolve a good chunk of dependency failures that ensued
deal with a large amount of the build time errors. updated graphql on the client side and get errors. created ticket CH-196 for it
remove stats tab v2. can bring back once it's done
remove reference to lineagefeatures
add siblings search capabilities on the BE
add BE functionality for display properties
add schema field status
remove fields on query fragment that didn't exist in backend.
update alchemy-components to be consistent with saas
remove v2 governance tab, update broken graphql files to match saas
clean up the Validations folder for observability to work in OSS
support siblingsSearch in the UI
fix lint before removing auto-generated files and rebuilding
fix up linting after removing auto-gen graphql files, main blocking ones are new features for their own commits
add timeline.graphql and the timeline feature
remove custom name/icon and custom help link
remove chunk of linting issues from missing/wrong impl
fix another chunk of linting issues to get below 100
remove some more linting issues before tackling specific features one at a time
fix(web) correctly determine if on siblings page #4987
implement the replacement feature on deprecation
update entity privileges to include new checks
implement full size search card view
implement entity notes feature
remove rest of proposals references
return chrome extension config, update list queries input/resolver, fix a few linting issues
add lineage feature flags
make some more changes to assertions to remove refs to monitors
add more events, fix a few more linting issues
add more flags and events and clean up more linting
finish linting issues except for observe stuff
fix up frontend tests failing
get nav bar redesign wired up
add additional styles for nav bar redesign
remove duplicate entry in entity type urn mapper
fix bugs from cypress test and cypress tests themselves
get linting totally clean
fix lint in cypress
update assertion.graphql to fix bug with opening assertion drawer
add back share menu for copying urns and what not in the UI
fix onboarding tour and storing v2 and nav bar redesign flags in local storage properly
add missed references to useIsThemeV2
add V2 cypress tests
fix bug with onboarding tour caught by cypress tests
add features tab to v2 settings
Checklist