Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Introducing the Alchemy UI #12474

Conversation

chriscollins3456
Copy link
Collaborator

@chriscollins3456 chriscollins3456 commented Jan 28, 2025

This is still a work in progress PR in order to fix up some failing tests and known bugs.

This PR introduces a whole new experience to the DataHub UI! We now give you the ability to choose your own DataHub adventure by utilizing the brand new Alchemy UI. This new interface simplifies a lot of the user experience, adds new functionality throughout the app, and adds beautiful new coat of paint to the DataHub you all know and love.

image image image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Jan 28, 2025
@chriscollins3456 chriscollins3456 added publish-docker and removed product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Jan 28, 2025
@datahub-cyborg datahub-cyborg bot added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Jan 28, 2025
update app providers, protexted routes, constant, and fix urn mapper

add homeV2 and sharedV2

add configV2

add entityV2

add searchV2

add previewV2

add settingsV2

add lineageV2

add glossaryV2

add domainV2

work through as many bad references etc. deleting things and adding things that needed to be added. UI now opens, but stuck on introduce page.

update SearchRoutes.tsx to point to v2 pages

remove platform folder and add a few missing svgs

remove majority of inferred documentation stuff. still some references there though

clean up more isInferred and other linting issues

remove documentation forms flag check

make es lint rules consistent for no cycles

remove metadata sharing feature

fix broken glass preventing UI from coming up

fix global styles and look

add connection to entity profile page V2 and resolve a good chunk of dependency failures that ensued

deal with a large amount of the build time errors. updated graphql on the client side and get errors. created ticket CH-196 for it

remove stats tab v2. can bring back once it's done

remove reference to lineagefeatures

add siblings search capabilities on the BE

add BE functionality for display properties

add schema field status

remove fields on query fragment that didn't exist in backend.

update alchemy-components to be consistent with saas

remove v2 governance tab, update broken graphql files to match saas

clean up the Validations folder for observability to work in OSS

support siblingsSearch in the UI

fix lint before removing auto-generated files and rebuilding

fix up linting after removing auto-gen graphql files, main blocking ones are new features for their own commits

add timeline.graphql and the timeline feature

remove custom name/icon and custom help link

remove chunk of linting issues from missing/wrong impl

fix another chunk of linting issues to get below 100

remove some more linting issues before tackling specific features one at a time

fix(web) correctly determine if on siblings page datahub-project#4987

implement the replacement feature on deprecation

update entity privileges to include new checks

implement full size search card view

implement entity notes feature

remove rest of proposals references

return chrome extension config, update list queries input/resolver, fix a few linting issues

add lineage feature flags

make some more changes to assertions to remove refs to monitors

add more events, fix a few more linting issues

add more flags and events and clean up more linting

finish linting issues except for observe stuff

fix up frontend tests failing

get nav bar redesign wired up

add additional styles for nav bar redesign

remove duplicate entry in entity type urn mapper

fix bugs from cypress test and cypress tests themselves

get linting totally clean

fix lint in cypress

update assertion.graphql to fix bug with opening assertion drawer

add back share menu for copying urns and what not in the UI

fix onboarding tour and storing v2 and nav bar redesign flags in local storage properly

add missed references to useIsThemeV2

add V2 cypress tests

fix bug with onboarding tour caught by cypress tests

add features tab to v2 settings
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 45.77053% with 5289 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...act/src/app/entityV2/dashboard/DashboardEntity.tsx 29.95% 283 Missing ⚠️
...b-web-react/src/app/entityV2/chart/ChartEntity.tsx 29.41% 276 Missing ⚠️
...ahub-web-react/src/app/entityV2/EntityRegistry.tsx 34.41% 242 Missing ⚠️
...act/src/app/entityV2/container/ContainerEntity.tsx 34.05% 184 Missing ⚠️
...react/src/app/entityV2/dataFlow/DataFlowEntity.tsx 34.22% 173 Missing ⚠️
...b-web-react/src/app/domainV2/CreateDomainModal.tsx 26.40% 170 Missing ⚠️
datahub-web-react/src/app/domainV2/DomainsList.tsx 20.67% 165 Missing ⚠️
...ub-web-react/src/app/entity/shared/siblingUtils.ts 39.21% 155 Missing ⚠️
...components/components/SelectItemsPopover/hooks.tsx 16.66% 140 Missing ⚠️
...ents/components/SelectItemsPopover/SelectItems.tsx 44.70% 120 Missing ⚠️
... and 115 more
Files with missing lines Coverage Δ
datahub-web-react/src/App.tsx 70.70% <100.00%> (+0.29%) ⬆️
...components/components/CalendarChart/components.tsx 100.00% <100.00%> (ø)
...y-components/components/CalendarChart/constants.ts 100.00% <100.00%> (ø)
...chemy-components/components/CalendarChart/index.ts 100.00% <100.00%> (ø)
...ents/components/CalendarChart/private/constants.ts 100.00% <100.00%> (ø)
...my-components/components/DatePicker/components.tsx 100.00% <100.00%> (ø)
...hemy-components/components/DatePicker/constants.ts 100.00% <100.00%> (ø)
.../alchemy-components/components/DatePicker/index.ts 100.00% <100.00%> (ø)
...ts/components/DatePicker/variants/common/props.tsx 100.00% <100.00%> (ø)
...ponents/DatePicker/variants/dateSwitcher/props.tsx 100.00% <100.00%> (ø)
... and 163 more

... and 1140 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca95cc...0950be0. Read the comment docs.

@chriscollins3456
Copy link
Collaborator Author

closing in favor of: #12481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-response Issue/request has been reviewed but requires a response from the submitter publish-docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants