Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion/kafka): add profiling functionality taking samples to produce profile #12340

Draft
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

acrylJonny
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@acrylJonny acrylJonny marked this pull request as draft January 14, 2025 21:32
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 75.32468% with 114 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...estion/src/datahub/ingestion/source/kafka/kafka.py 60.23% 68 Missing ⚠️
...c/datahub/ingestion/source/kafka/kafka_profiler.py 82.50% 46 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.32%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
...src/datahub/ingestion/source/kafka/kafka_config.py 100.00% <100.00%> (ø)
...c/datahub/ingestion/source/kafka/kafka_profiler.py 82.50% <82.50%> (ø)
...estion/src/datahub/ingestion/source/kafka/kafka.py 79.41% <60.23%> (-14.63%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f8d17...62478b8. Read the comment docs.

@acrylJonny acrylJonny changed the title feat(ingestion/kafka): add option to add sample values feat(ingestion/kafka): add profiling functionality taking samples to produce profile Jan 19, 2025
@acrylJonny acrylJonny marked this pull request as ready for review January 21, 2025 09:43
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 21, 2025
@acrylJonny acrylJonny marked this pull request as draft January 26, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant