-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion/snowflake):adds streams as a new dataset with lineage and properties. #12318
Open
brock-acryl
wants to merge
44
commits into
datahub-project:master
Choose a base branch
from
brock-acryl:snowflake-streams-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,783
−1,811
Open
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
a268e3e
merged changes from master
brock-acryl b7dfa7c
- moved stream_pattern from sql_config.py to snowflake_config.py
brock-acryl 30f2e53
added streams to docs
brock-acryl e0b3c3b
- removed unused method
brock-acryl f0124e2
Merge branch 'master' into snowflake-streams-v2
brock-acryl 2ff19ba
merge changes
brock-acryl fd87ca9
lintfix
brock-acryl 11c6b8c
Refactored _process_schema into smaller functions
brock-acryl b06d0bd
fixed streams_for_database
brock-acryl 2968f6c
Merge branch 'master' into snowflake-streams-v2
brock-acryl 5f25f3c
updated pytests and golden files
brock-acryl 18770a9
lintfix
brock-acryl f726f38
code review updates.
brock-acryl 59c21c7
Merge branch 'master' into snowflake-streams-v2
brock-acryl 0d95fcd
lint
brock-acryl 6ad3f70
lint
brock-acryl c20aa2d
updated tests
brock-acryl 67b8212
Merge branch 'master' into snowflake-streams-v2
brock-acryl af9d421
updated tests
brock-acryl c1f0be8
updated reporting
brock-acryl b97724a
Merge branch 'master' into snowflake-streams-v2
brock-acryl 07cf0bd
Merge branch 'snowflake-streams-v2' of github.com:brock-acryl/datahub…
brock-acryl 623ecb5
Merge branch 'master' into snowflake-streams-v2
brock-acryl ade6503
- Updated docs with required permissions
brock-acryl d67a22f
Merge branch 'master' into snowflake-streams-v2
brock-acryl 3a25dd9
- added logic to filter information schema columns for only
brock-acryl 96b16d2
Merge branch 'master' into snowflake-streams-v2
brock-acryl 13bb2ec
- added logic to filter information schema columns for only
brock-acryl f46a418
Update metadata-ingestion/src/datahub/ingestion/source/snowflake/snow…
brock-acryl 5199366
Update metadata-ingestion/src/datahub/ingestion/source/snowflake/snow…
brock-acryl 150b12a
Merge branch 'master' into snowflake-streams-v2
brock-acryl b719ffb
- removed tags from streams, streams don't have tags on columns
brock-acryl 7b68003
- removed tags from streams, streams don't have columns so they don't…
brock-acryl a41aac4
- updated golden files
brock-acryl 8b41101
- test fix
brock-acryl 619efc3
- test fix
brock-acryl 0527c23
reverted to add_known_lineage_mapping for streams
brock-acryl 217c295
Merge branch 'master' into snowflake-streams-v2
brock-acryl 68cbe87
Merge branch 'snowflake-streams-v2' of github.com:brock-acryl/datahub…
brock-acryl 16bdca2
Update metadata-ingestion/src/datahub/ingestion/source/snowflake/snow…
brock-acryl 457dab7
removed extra yield
brock-acryl 21cb6c2
Merge branch 'master' into snowflake-streams-v2
brock-acryl f82685e
lintfix
brock-acryl 0756e5d
Merge branch 'master' into snowflake-streams-v2
brock-acryl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is redundant, since it inherits from
SnowflakeFilterConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the code