Fix admin profil #546
Merged
Fix admin profil #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maudetes
approved these changes
Sep 30, 2024
| > | ||
| <div class="fr-grid-row fr-grid-row--gutters fr-grid-row--middle justify-between"> | ||
| <div class="fr-col-12 fr-col-md fr-grid-row fr-grid-row--middle"> | ||
| <Placeholder |
There was a problem hiding this comment.
I find it slightly counter-intuitive that the logo appears at the top of the page but is editable at the end of the form only
cc @agarrone
udata_front/theme/gouvfr/assets/js/pages/Admin/Profile/Profile.vue
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| onMounted(async () => me.value = await fetchMe()); |
There was a problem hiding this comment.
Don't we need to fetch me.value here?
There was a problem hiding this comment.
No, this was necessary before the Dataset PR merge. Now we have access to the useCurrentOrganization composable instead
..._front/theme/gouvfr/assets/js/pages/OrganizationPublishingForm/Step2DescribeOrganization.vue
Outdated
Show resolved
Hide resolved
| @@ -12,7 +12,6 @@ | |||
| {% block extra_css %}{% endblock %} | |||
| {% block theme_css %} | |||
| <link href="{{ theme_static('assets/style.css') }}" rel="stylesheet"> | |||
| <link href="{{ theme_static('assets/index.css') }}" rel="stylesheet"> | |||
There was a problem hiding this comment.
👀 Have we had this broken css import for years?
There was a problem hiding this comment.
No, this css file is now merged in style.css since the changes to the way we import datagouv/components. We added cssCodeSplit: false to the build so this file was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes datagouv/data.gouv.fr#1450
It also removes duplicated types and components.