Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Expose StripeFactory so users can write them in struct #9

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Oct 28, 2024

This PR will expose StripeFactory so users can write in a struct like:

pub struct ORCSourceForCopy {
    table_ctx: Arc<dyn TableContext>,
    scan_progress: Arc<Progress>,
    op: Operator,
    reader: Option<(
        String,
        Box<StripeFactory<OrcChunkReader>>,
        HashableSchema,
        usize,
    )>,
}

I'm not sure if that's the best API we can have, maybe we can polish this part later.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested review from waynexia and WenyXu October 28, 2024 07:09
Copy link
Collaborator

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 LGTM

@waynexia waynexia merged commit cf87633 into main Oct 28, 2024
12 checks passed
@waynexia waynexia deleted the expose-strip-factory branch October 28, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants