Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrow version requirement #12

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

progval
Copy link
Collaborator

@progval progval commented Oct 29, 2024

Building with arrow 53.0.0 fails with:

error[E0277]: the trait bound `arrow::buffer::Buffer: From<Vec<u8>>` is not satisfied
   --> /home/dev/.cargo/registry/src/index.crates.io-6f17d22bba15001f/orc-rust-0.5.0/src/array_decoder/string.rs:133:21
    |
133 |         let bytes = Buffer::from(bytes);
    |                     ^^^^^^ the trait `From<Vec<u8>>` is not implemented for `arrow::buffer::Buffer`

Building with arrow 53.0.0 fails with:

```
error[E0277]: the trait bound `arrow::buffer::Buffer: From<Vec<u8>>` is not satisfied
   --> /home/dev/.cargo/registry/src/index.crates.io-6f17d22bba15001f/orc-rust-0.5.0/src/array_decoder/string.rs:133:21
    |
133 |         let bytes = Buffer::from(bytes);
    |                     ^^^^^^ the trait `From<Vec<u8>>` is not implemented for `arrow::buffer::Buffer`
```
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @progval for fixing this!

@Xuanwo Xuanwo merged commit f934c8e into datafusion-contrib:main Oct 29, 2024
12 checks passed
@progval progval deleted the patch-1 branch October 29, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants