Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DB CatalogProvider #175

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Add DB CatalogProvider #175

merged 5 commits into from
Nov 20, 2024
+508 −98

Conversation

holicc
Copy link
Contributor

@holicc holicc commented Nov 19, 2024

@holicc holicc changed the title WIP: Add DB CatalogProvider Add DB CatalogProvider Nov 19, 2024
@holicc holicc mentioned this pull request Nov 19, 2024
Closed
phillipleblanc
phillipleblanc approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@phillipleblanc phillipleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thanks! Just have a few minor comments and I'll merge this.

examples/duckdb.rs Show resolved Hide resolved
examples/mysql.rs Show resolved Hide resolved
src/common.rs Outdated Show resolved Hide resolved
src/common.rs Outdated Show resolved Hide resolved
holicc and others added 3 commits November 20, 2024 09:44
@holicc @phillipleblanc
fix: typo
2179af3 
Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
@holicc @phillipleblanc
fix: typo
05e7b46 
Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
@holicc
Enhance examples with comprehensive table access demonstrations
1db7ac8
@phillipleblanc phillipleblanc merged commit 3920c32 into datafusion-contrib:main Nov 20, 2024
3 checks passed
@phillipleblanc
Copy link
Collaborator

Thanks again @holicc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holicc @phillipleblanc