Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests #144

Merged
merged 1 commit into from
Oct 19, 2024
Merged

fix tests #144

merged 1 commit into from
Oct 19, 2024

Conversation

ccciudatu
Copy link
Collaborator

cargo test --lib --all-features currently fails with:

error[E0308]: mismatched types
   --> src/sql/db_connection_pool/sqlitepool.rs:285:78
    |
285 |         let factory = SqliteConnectionPoolFactory::new(&db_name, Mode::File, None);
    |                       --------------------------------                       ^^^^ expected `Duration`, found `Option<_>`
    |                       |
    |                       arguments to this function are incorrect
    |
    = note: expected struct `std::time::Duration`
                 found enum `std::option::Option<_>`
note: associated function defined here
   --> src/sql/db_connection_pool/sqlitepool.rs:33:12
    |
33  |     pub fn new(path: &str, mode: Mode, busy_timeout: Duration) -> Self {
    |            ^^^                         ----------------------

@ccciudatu ccciudatu merged commit e9a53cf into datafusion-contrib:main Oct 19, 2024
3 checks passed
@ccciudatu ccciudatu deleted the test-fix branch October 19, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants