-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MySQL write support #134
Conversation
Summary of Changes
Dependency
|
@gengteng I'll look at reviewing this PR over the next week. Do you know why the integration test is failing? |
Hi @phillipleblanc , The integration test is failing because it depends on another PR, feat: add support for converting LargeUtf8/LargeString in try_cast_to (datafusion-federation#71). The test code in my PR uses changes introduced in that PR. Once it’s merged and released, the test should pass. If you could help push for that PR to be merged, it would be greatly appreciated. Alternatively, I could extract the relevant logic into this PR, but that would result in code duplication. Or do you have any better suggestions? Thank you for reviewing! |
…ql feature checks
I've reviewed the PR in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! I have a couple of comments, but this is looking good.
resolve #122 |
@gengteng Is this PR still in progress? I recently needed this feature, and if there's anything I can do to help, I'd be happy to assist. :) |
6718932
to
6807da2
Compare
6807da2
to
b71a513
Compare
Hi @holicc, Thank you so much for offering to help—I really appreciate it! 😊 I’ve resolved all issues locally and merged the latest version. All tests pass successfully on my local machine. However, the tests are still failing on GitHub Actions, possibly due to memory or disk space limitations (exit code 143). Could you please help check if there are resource constraints or other underlying issues? Thanks again for your assistance! |
Yes, all tests have passed on my laptop too. It seems the problem is not with the code. @phillipleblanc, can you retry the actions? |
Thanks @gengteng! |
Hey @phillipleblanc ,
I’ve got an initial version of the MySQL write support ready. No tests or manual validation yet, but I wanted to get this PR up and continue working on those next.
Cheers!