Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add boilerplate and json_obj_contains #1

Merged
merged 6 commits into from
Apr 22, 2024
Merged

add boilerplate and json_obj_contains #1

merged 6 commits into from
Apr 22, 2024

Conversation

samuelcolvin
Copy link
Collaborator

Using pydantic/jiter#84 to skip values.

uses: Swatinem/rust-cache@v2

- run: cargo test --all-features
# - uses: taiki-e/install-action@cargo-llvm-cov
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb this is currently not working as datafusion-functions-json is inactive on codecov, please can you enable it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samuelcolvin -- I am not sure what you want me to do here. How do I enable code-cov?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you go to https://app.codecov.io/github/datafusion-contrib and there's a button to enable this repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

I added the required repository secret (I think) as CODECOV_TOKEN

The instructions on https://app.codecov.io/github/datafusion-contrib/datafusion-functions-json/new now say

Step 2: add Codecov to your GitHub Actions workflow yaml file
After tests run, this will upload your coverage report to Codecov:

- name: Upload coverage reports to Codecov
  uses: codecov/codecov-action@v4.0.1
  with:
    token: ${{ secrets.CODECOV_TOKEN }}
    slug: datafusion-contrib/datafusion-functions-json

@samuelcolvin samuelcolvin merged commit a27344c into main Apr 22, 2024
5 checks passed
@samuelcolvin samuelcolvin deleted the json_contains branch April 22, 2024 10:11
@davidhewitt davidhewitt mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants