Added i18n translations to tile components #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmechali
approved these changes
Feb 7, 2025
beets
approved these changes
Feb 7, 2025
static/js/i18n/strings/en/place.json
Outdated
| }, | ||
| "chart-title-with-two-variables-and-location": { | ||
| "defaultMessage": "{variable1} Vs. {variable2} in {placeType} of {place}", | ||
| "description": "Chart title for a chart comparing two different variables, for places of a specific type within a place. For example, this could be Obesity Rate Vs. Income in States of USA, or Housing vs Poverty in Countries of Europe." |
There was a problem hiding this comment.
would be good to clarify the example title with quotes.
static/js/i18n/strings/en/place.json
Outdated
| "header-overview": { | ||
| "defaultMessage": "Overview", | ||
| "description": "Text for header or subheader of Overview charts on place pages." | ||
| }, | ||
| "key_demographics": { | ||
| "defaultMessage": "Key Demographics", |
There was a problem hiding this comment.
Should this be sentence case (along with some of these other titles below)
static/js/i18n/strings/en/place.json
Outdated
| }, | ||
| "viaGoogle": { | ||
| "defaultMessage": "via Google", | ||
| "description": "Indicator displayed when chart data comes from Google" |
There was a problem hiding this comment.
an example string where this is used would be helpful
Added a basic test, and added a TODO to update some of the assertions once we have actual translations in place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intl. formatMessagecalls to hardcoded strings in tile components/api/place/displaynamecalls. (Still todo: Add locale param support to /api/place/name)