Update place page summaries #4875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnoble
reviewed
Jan 22, 2025
| }, | ||
| "country/ARG": { | ||
| "summary": "Argentina is a country in South America. The population in Argentina was 45,808,747 in 2021. The nominal GDP per capita in Argentina was $10,636.12 in 2021. The Gini index in Argentina was 42 in 2021. The life expectancy in Argentina was 75.39 in 2021. The energy consumption per capita in Argentina was 2,029.92kg in 2014. The carbon dioxide emissions per capita in Argentina was 3.41t in 2020." | ||
| "summary": "Argentina is a country in South America. The population in Argentina was 46,654,581 in 2023. The nominal GDP per capita in Argentina was $13,730.51 in 2023. The Gini index in Argentina was 40.7 in 2022. The life expectancy in Argentina was 76.06 in 2022. The energy consumption per capita in Argentina was 2,029.92kg in 2014. The carbon dioxide emissions per capita in Argentina was 3.41t in 2020." |
There was a problem hiding this comment.
Running a spot check here- looks like the population values im seeing in the table (45,538,401) don't line up with the value here (46,654,581)
(link: https://autopush.datacommons.org/place/country/ARG?force_dev_places=true)
There was a problem hiding this comment.
Looks like there was a data update between this run and when you got the screenshots. Rerunning the script has updated the numbers to match. I spot checked a couple places after the re-run, and the population numbers appear to match now:
dwnoble
added a commit
that referenced
this pull request
Jan 25, 2025
- Updated key demographics variable names to match figma mocks - Added localization support to display values, units, and dates - Moved overview table data fetch path from the client side to the server side (new endpoint: `/api/dev-place/overview-table/<place-dcid>` for a performance boost. - @juliawu - this also changes the data fetching strategy a bit. Can you take a look and see if my comment from #4875 still applies? Before:  After: 
rohitkumarbhagat
pushed a commit
to rohitkumarbhagat/website
that referenced
this pull request
Jan 27, 2025
…acommonsorg#4884) - Updated key demographics variable names to match figma mocks - Added localization support to display values, units, and dates - Moved overview table data fetch path from the client side to the server side (new endpoint: `/api/dev-place/overview-table/<place-dcid>` for a performance boost. - @juliawu - this also changes the data fetching strategy a bit. Can you take a look and see if my comment from datacommonsorg#4875 still applies? Before:  After: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Updates the data values used in place page summaries to more recent data.
(2) Cleans up the summary generation code, adding a new utility function.