2024-11-12 Custom DC stable release #4733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add multi-hop properties needed for the hero queries - Update multi-hop properties where naming has changed from data cleanup - Update entity overview tile to link to the browser page for ease of testing
…onsorg#4714) Hopefully this will resolve custom DC autopush test failures.
- Remove some landing page example links that don't work anymore - Add parallelization for Custom DC autopush tests - Add some waiting for elements to be ready in tests that were failing on Cloud Build
- when multiple entities are recognized but only some entities have data for the property, should only show the entities with data (e.g., [autopush](https://screenshot.googleplex.com/48VaUAxjZtXYMgC) vs [local](https://screenshot.googleplex.com/Brsnuj4DSNmpJSN)) - fix bug in deciding when to show low confidence message. Previously did not consider property score
…hm. (datacommonsorg#4716) Places like Curaçao, España, or Algérie were being unfairly demoted in scoring due to the non-ascii character. This PR replaces all special characters before determine the match score. Screencast with the fix: https://screencast.googleplex.com/cast/NDkzOTc5NTE5MjA4NjUyOHw1N2FlYTVmMC00Zg
…tacommonsorg#4718) Reduces CosineScores to 6 decimals to reduce the diffs that are generated when updating the integration_test goldens. This is to reduce noise in reviews and should not fundamentally affect the actual tests.
looks like the class name for topic items got changed in this PR causing sanity tests to fail: https://github.com/datacommonsorg/website/pull/4673/files#diff-37059329da755a92aa218821e795bf1cb89ad26682ceb8f6d5dddc84a49bb645L43
Adds: - mechanismOfAction - hgncID - inChIKey Updates: - unifiedMedicalLanguageSystemConceptUniqueIdentifier -> umlsConceptUniqueID - ncbiTaxonID->ncbiTaxId - referenceAlleleNCBI -> referenceAllele - genomicCoordinates -> hasGenomicCoordinates Deletes: - diseaseName - observedAllele - hg19GenomicPosition - hg19GenomicLocation - hg38GenomicPosition - hg38GenomicLocation - hasRNATranscript - ncbiDNASequenceName - imageUrl - availableStrength Example Screenshots   
## Description This PR implements the redesign of the explorer landing page page. The first part of the PR converts the page to a React app with components followed by a reworking of the page into the new layout. The link content for the stat var chips have been added to the same `TopicConfig` as the general and comparison query links. The link chip component has been generalized to contain a variant for the stat var chips. --------- Co-authored-by: Pablo Noel <pablo@next-solutions.ca>
# Summary - Include remediation instructions in error message. - Rename check file to "Release branch checks" (release-branch-checks.yml) - This makes the prefix of the check where it's listed on a PR non-redundant, and also sets us up to potentially have more checks in there in the future. - I've called it "Release branch checks" instead of "Custom DC stable branch checks" because technically the same checks would apply if we ever wanted to use release branches for website prod and staging. - Rename job to "verify_all_commits_are_already_in_master" so the name makes sense on its own. Also, update version of checkout action to one that isn't about to be deprecated. # Screenshots ## On PR  ## After clicking through from PR  ## In Actions tab  ## After clicking through from Actions tab 
…rg#4730) Autocomplete queries only trigger on 3+ letter words. With this change, we add one exception, to trigger on a two letter word if that is "US" US Triggers: https://screenshot.googleplex.com/AzqxmiqBBr2ocVn Other 2 letter words do not: https://screenshot.googleplex.com/7tXxN8p34MT4SUU Life expectancy in us: https://screenshot.googleplex.com/6k7WK2oiJqWedxK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Summarize changes since last stable release.