-
Notifications
You must be signed in to change notification settings - Fork 91
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Feature Flags] Give custom DC their own checked in flags. (#4934)
Creates a local file with the feature flags to be used in Custom DC. Sets autocomplete and place page flags to be disabled (note that the screenshot had place experiment enabled, but it's now disabled). Starts reading the flags for custom DC from the local file, and injects them in the custom DC base.html file. See how local custom DC now has the scroll to top button: https://screenshot.googleplex.com/7dk4eim4LALCuVL
- Loading branch information
Showing
3 changed files
with
28 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
[{ | ||
"name": "autocomplete", | ||
"enabled": false, | ||
"owner": "gmechali", | ||
"description": "Feature flag to enable place autocomplete." | ||
}, | ||
{ | ||
"name": "dev_place_experiment", | ||
"enabled": false, | ||
"owner": "gmechali", | ||
"description": "Feature flag to enable the V2 place page only for the experiment places." | ||
}, | ||
{ | ||
"name": "dev_place_ga", | ||
"enabled": false, | ||
"owner": "dwnoble", | ||
"description": "Feature flag to enable the V2 Place page to GA." | ||
}, | ||
{ | ||
"name": "scroll_to_top_button", | ||
"enabled": true, | ||
"owner": "gmechali", | ||
"description": "Feature flag to enable the scroll to top button on the explore and place pages." | ||
}] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters