Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LE-591] Update to use previous version of testthat #4

Merged
merged 2 commits into from
May 3, 2019
Merged

[LE-591] Update to use previous version of testthat #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07518dc
Update reporter-project.R
machow May 2, 2019
0a70834
Bump patch version
TimSangster May 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: IRkernel.testthat
Title: What the Package Does (one line, title case)
Version: 0.2.0
Version: 0.2.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird you bump the version in the middle of the PR. With JS package, a commit is added on top of master and receive the appropriate tag. No idea if there is any similar practice for R though.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know but makes sense! Thank you, next time I'll do it the correct way.

Authors@R: person("Michael", "Chow", email = "michael@datacamp.com", role = c("aut", "cre"))
Description: Implements reporter for communicating testthat results to a jupyter client.
License: All Rights Reserved
Expand Down
2 changes: 1 addition & 1 deletion R/reporter-project.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ ProjectReporter <- R6::R6Class("ProjectReporter", inherit = testthat::ListReport
lapply(test$results, `[[`, 'message'),
collapse = '\n')

res <- testthat:::sumarize_one_test_results(test)
res <- testthat:::summarize_one_test_results(test)
success <- !any(res$failed, res$error)
# figure out outcome, e.g. for counting errors later
if (!success) {
Expand Down