Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default UCX installation folder to /Applications/ucx from /Users/<me>/.ucx to allow multiple users users utilising the same installation #854

Merged
merged 40 commits into from
Mar 11, 2024
Merged

Changed default UCX installation folder to /Applications/ucx from /Users/<me>/.ucx to allow multiple users users utilising the same installation #854

Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
3ad37bf
WIP integration and unit tests
pritishpai Jan 31, 2024
a86cda1
Seperating the integration tests
pritishpai Jan 31, 2024
04915ae
Removing older private method call
pritishpai Feb 1, 2024
63811cd
Added unit test
pritishpai Feb 1, 2024
b1a70f3
Initial commit
pritishpai Feb 5, 2024
f432af0
Integration tests
pritishpai Feb 5, 2024
84e2efc
Linting changes
pritishpai Feb 5, 2024
6c09cc1
Changing workspace root folder
pritishpai Feb 5, 2024
76ec017
PR code changes
pritishpai Feb 15, 2024
785bd31
Fixed unit tests
pritishpai Feb 15, 2024
3fa7cc4
Add reinstall on existing integration tests
pritishpai Feb 19, 2024
a0e72c4
Changes with all install scenarios
pritishpai Feb 23, 2024
6e3965a
Install changes, integration tests and error handling
pritishpai Mar 2, 2024
297bea5
Force install integration tests.
pritishpai Mar 2, 2024
1af8651
Fix linting
pritishpai Mar 2, 2024
6526cf3
Fix older tests
pritishpai Mar 2, 2024
b1805c7
Unit tests for get_existing_installation
pritishpai Mar 3, 2024
34d7ebf
Unit tests for _check_inventory_database_exists
pritishpai Mar 3, 2024
1022474
Commit missed code file
pritishpai Mar 3, 2024
d292644
Fix PRODUCT_INFO mocking
pritishpai Mar 4, 2024
a1d57ae
Fix failing unit tests
pritishpai Mar 7, 2024
0551c51
Rebasing and adjusting for new install logic
pritishpai Mar 7, 2024
547c803
Inject PRODUCT_INFO via constructor
pritishpai Mar 7, 2024
c23fd4a
Install logic implemented, unit tests
pritishpai Mar 8, 2024
158c8b7
Integration tests updated
pritishpai Mar 8, 2024
b56ad97
Minor fix and README
pritishpai Mar 8, 2024
9d6cf68
Fix pylint error
pritishpai Mar 8, 2024
60e3c90
Increase cov#1
pritishpai Mar 8, 2024
88043e1
Remove unreachable code
pritishpai Mar 8, 2024
58f4258
PR comments
pritishpai Mar 8, 2024
ba737e7
Update ToC in README
pritishpai Mar 8, 2024
9c2d3a3
PR Comments#2
pritishpai Mar 8, 2024
72741d3
Removing newlines
pritishpai Mar 8, 2024
b098072
Fixing linting #3
pritishpai Mar 8, 2024
e7f634b
- Inject `ProductInfo` into `WorkspaceInstallation` and `WorkspaceIns…
nfx Mar 9, 2024
a0abdd6
Use injection instead of patch for UCX_FORCE_INSTALL
pritishpai Mar 9, 2024
3f0733d
Updated integrations tests with injection
pritishpai Mar 10, 2024
dbd8211
Fmt and linting
pritishpai Mar 10, 2024
a0d572f
Fix missing variable
pritishpai Mar 10, 2024
97d14d2
pick global install by default
nfx Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unreachable code
  • Loading branch information
@pritishpai
pritishpai committed Mar 10, 2024
commit 88043e1b2e3d1f39eeac5e7b830e11ab8caba398
2 changes: 1 addition & 1 deletion src/databricks/labs/ucx/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

import databricks.sdk.errors
from databricks.labs.blueprint.entrypoint import get_logger
from databricks.labs.blueprint.installation import Installation, NotInstalled
from databricks.labs.blueprint.installation import Installation
from databricks.labs.blueprint.installer import InstallState
from databricks.labs.blueprint.parallel import ManyError, Threads
from databricks.labs.blueprint.tui import Prompts
Expand Down