Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runnable on nightly testing infrastructure #75

Merged
merged 4 commits into from
Aug 10, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleanup invalid code
  • Loading branch information
nfx committed Aug 10, 2023
commit 10d5c1d6a21a68bc969eb6d4dd286bd59e21c0ac
2 changes: 1 addition & 1 deletion tests/integration/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
_create_groups,
_get_basic_job_cluster,
_get_basic_task,
_set_random_permissions
_set_random_permissions,
)

logging.getLogger("databricks.sdk").setLevel(logging.INFO)
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/test_jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from pyspark.errors import AnalysisException

from uc_migration_toolkit.config import (
ConnectConfig,
GroupsConfig,
InventoryConfig,
InventoryTable,
Expand All @@ -25,6 +26,7 @@ def test_jobs(
logger.debug(f"Test environment: {env.test_uid}")

config = MigrationConfig(
connect=ConnectConfig.from_databricks_config(ws.config),
with_table_acls=False,
inventory=InventoryConfig(table=inventory_table),
groups=GroupsConfig(selected=[g[0].display_name for g in env.groups]),
Expand Down
3 changes: 1 addition & 2 deletions tests/integration/utils.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import random
from dataclasses import dataclass
from functools import partial
from pathlib import Path
from typing import Any

from databricks.sdk import AccountClient, WorkspaceClient
Expand All @@ -15,13 +14,13 @@
)
from databricks.sdk.service.jobs import JobCluster, PythonWheelTask, Task
from databricks.sdk.service.workspace import ObjectInfo
from dotenv import load_dotenv

from uc_migration_toolkit.managers.inventory.types import RequestObjectType
from uc_migration_toolkit.providers.client import ImprovedWorkspaceClient
from uc_migration_toolkit.providers.logger import logger
from uc_migration_toolkit.utils import WorkspaceLevelEntitlement


@dataclass
class InstanceProfile:
instance_profile_arn: str
Expand Down