Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import member issue #3056

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix import member issue #3056

merged 2 commits into from
Oct 24, 2024
+53 −1

Conversation

ericvergnaud
Copy link
Contributor

Changes

Our current implementation does not properly collect imports when source code uses indirect import patterns such as:

from importlib import import_module
module = import_module("some-module")

This PR fixes that

Linked issues

None

Functionality

None

Tests

  • added unit tests

@ericvergnaud ericvergnaud requested a review from a team as a code owner October 24, 2024 11:10
@ericvergnaud ericvergnaud changed the base branch from main to fix-dynamic-import-issue October 24, 2024 11:10
@github-actions GitHub Actions
Copy link

✅ 47/47 passed, 2 skipped, 33m1s total

Running from acceptance #7018

nfx
nfx approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit 1c8c3e6 into fix-dynamic-import-issue Oct 24, 2024
6 of 7 checks passed
@nfx nfx deleted the fix-import-member-issue branch October 24, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericvergnaud @nfx