[TECH DEBT] Add type hints for cached properties #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
commented
Oct 3, 2024
| return GlobalInitScriptCrawler(self.workspace_client, self.sql_backend, self.inventory_database) | ||
|
|
||
| @cached_property | ||
| def tables_crawler(self): | ||
| # TODO: Update tables crawler inheritance to specify return type hint |
There was a problem hiding this comment.
@pritishpai : Could you solve this in a separate PR?
32dd02f to
751a9ed
Compare
751a9ed to
fe65226
Compare
24d4010 to
e5fd2d4
Compare
|
✅ 175/175 passed, 1 flaky, 4 skipped, 4h19m59s total Flaky tests:
Running from acceptance #6362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add type hints for cached properties and resolve the linting issues found after adding the type hints. Would have caught the integration test issues introduced in #2772