Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor contributor documentation changes #2729

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Minor contributor documentation changes #2729

merged 3 commits into from
Sep 24, 2024

Conversation

asnare
Copy link
Contributor

@asnare asnare commented Sep 24, 2024

Changes

This PR makes some minor changes to the the contributor documentation:

  • Hatch/env setup tweak to keep IntelliJ/PyCharm happy. (For some reason if the full path isn't specified IntelliJ can have problems locating the python interpreter for the venv.)
  • Add in the linting step.

IntelliJ fails to locate the python interpreter properly if the venv isn't setup with the full path to python.
@asnare asnare added documentation Improvements or additions to documentation internal this pull request won't appear in release notes labels Sep 24, 2024
@asnare asnare self-assigned this Sep 24, 2024
@asnare asnare requested a review from a team as a code owner September 24, 2024 08:36
Copy link

github-actions bot commented Sep 24, 2024

✅ 2/2 passed, 14s total

Running from acceptance #6066

CONTRIBUTING.md Outdated Show resolved Hide resolved
@nfx nfx merged commit 70abd21 into main Sep 24, 2024
6 checks passed
@nfx nfx deleted the project-setup branch September 24, 2024 10:18
jgarciaf106 pushed a commit to rportilla-databricks/ucx that referenced this pull request Sep 26, 2024
## Changes

This PR makes some minor changes to the the contributor documentation:

- Hatch/env setup tweak to keep IntelliJ/PyCharm happy. (For some reason
if the full path isn't specified IntelliJ can have problems locating the
python interpreter for the venv.)
 - ~Add in the linting step.~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal this pull request won't appear in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants